Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invisible buttons after changes in WireButton size parameters #2222

Merged
merged 6 commits into from
Sep 12, 2023

Conversation

saleniuk
Copy link
Contributor


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After minWidth and minHeight were grouped into minSize and second parameter minClickableSize added to customise the space button really takes if needed, some of the buttons that had size set directly in the passed modifier (Modifier.size(width = X, height = X)) ended up having paddings applied from the default minClickableSize and then size from modifier - in some cases it ended up with too small area for the button.

Solutions

Removed sizes that are added directly in the passed modifier, now it relies only on parameters defined specifically to handle button sizes (minSize and minClickableSize).
Added previews for all buttons that have minClickableSize defined.


References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@saleniuk saleniuk changed the title fix: invisible buttons after WireButton size changes fix: invisible buttons after changes in WireButton size parameters Sep 12, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

Test Results

587 tests   586 ✔️  7m 40s ⏱️
  84 suites      1 💤
  84 files        0

Results for commit d07201e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@yamilmedina yamilmedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it really quick and looks perfect 🙌

@AndroidBob
Copy link
Collaborator

Build 706 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 714 succeeded.

The build produced the following APK's:

@github-actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 721 succeeded.

The build produced the following APK's:

@saleniuk saleniuk merged commit fbb4c06 into release/candidate Sep 12, 2023
12 checks passed
@saleniuk saleniuk deleted the fix/missing_buttons_after_size_changes branch September 12, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants