-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invisible buttons after changes in WireButton size parameters #2222
fix: invisible buttons after changes in WireButton size parameters #2222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build 706 succeeded. The build produced the following APK's: |
…ing_buttons_after_size_changes
APKs built during tests are available here. Scroll down to Artifacts! |
Build 714 succeeded. The build produced the following APK's: |
APKs built during tests are available here. Scroll down to Artifacts! |
Build 721 succeeded. The build produced the following APK's: |
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
After
minWidth
andminHeight
were grouped intominSize
and second parameterminClickableSize
added to customise the space button really takes if needed, some of the buttons that had size set directly in the passedmodifier
(Modifier.size(width = X, height = X)
) ended up having paddings applied from the defaultminClickableSize
and then size from modifier - in some cases it ended up with too small area for the button.Solutions
Removed sizes that are added directly in the passed
modifier
, now it relies only on parameters defined specifically to handle button sizes (minSize
andminClickableSize
).Added previews for all buttons that have
minClickableSize
defined.References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.